Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent keyboard popup-keys group from wrapping to two lines #1221

Merged
merged 1 commit into from May 15, 2019
Merged

Prevent keyboard popup-keys group from wrapping to two lines #1221

merged 1 commit into from May 15, 2019

Conversation

MortimerGoro
Copy link
Contributor

Fixes #1180

@MortimerGoro MortimerGoro requested a review from cvan May 14, 2019 16:01
@MortimerGoro MortimerGoro self-assigned this May 14, 2019
@philip-lamb philip-lamb self-requested a review May 15, 2019 03:00
cvan
cvan approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@cvan cvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 excellent work!

I tested them all: I pressed every single alphabetical letter on the keyboard, and all of them displayed as I'd expected and without any wrapping issues.

@cvan cvan added this to the v1.2 milestone May 15, 2019
@MortimerGoro MortimerGoro merged commit 25b120f into release-1.2 May 15, 2019
@philip-lamb philip-lamb deleted the keyboard_popover_keys branch May 15, 2019 10:02
@philip-lamb philip-lamb mentioned this pull request May 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvan cvan cvan approved these changes

@philip-lamb philip-lamb philip-lamb approved these changes

Assignees

@MortimerGoro MortimerGoro

Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MortimerGoro @cvan @philip-lamb