New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not resize fullscreen window size if the window size is actually larger than the threshold. #1379
Conversation
38587ff
to
8ebffd4
Compare
I'm confused what the issue is and what the expected behavior should be. I feel like there should be two screen sizes. One for normal browsing and one for full screen. But is seems to me that no mater what size I set for the full screen window, it reverts to the standard window size next time? I also could not reproduce the clipping described in the STR for the issue. Am I missing a step? |
I also see a problem outside of the Hubs layout issue. STR:
Isn't it weird that fullscreen reduces the actual window size? If a user wants a youtube fullscreen video at 3X he can't because of this resize. cc @jvonitter This may require design decision. |
I agree that our window sizing is confusing. It rarely behaves the way I would expect and doesn't seem to retain the size I set it to. |
thanks for the heads up @MortimerGoro . I'll check in with UX about it |
Looking at it and need some time to reply... expect answers early next week. |
@thenadj and I just discussed this and we think you're right, sizing the screen down like that is weird. What we'd like to do is update the logic to be: Sound ok? |
Thanks! that logic is what the PR is supposed to do. |
8ebffd4
to
ddc1473
Compare
…igger than the fullscreen min size threshold
ddc1473
to
7f05ab5
Compare
Fixes #1362