New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements latest Settings spec #1423
Conversation
Awesome. Will give it a test tomorrow. |
fc993e3
to
9ec17a9
Compare
9ec17a9
to
295e764
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I have tried to switch between desktop and VR UAs. It works on the current page, but when browsing to other pages I got a desktop viewport while the
VR
icon was visible in the URL bar -
I think the
VR
text icon can be confusing for users. Can't we use a similar icon to the one used in Oculus browser? Toggle between the desktop icon with or without the checkmark. -
The
VR
icon is too close to the URL bar end on the content feed and looks misaligned. Should we hide it on the content feed? (in that case the bookmark icon is not visible)
cc @jvonitter @thenadj related to the checkmark idea I mentioned: Firefox desktop uses this icon to enable Firefox for iOS uses this icon to go back to |
I'm not sure if it is related but the first time I ran this PR only the main window was visible, no other UI was visible. I had to restart to see the rest of the UI like navigation bar and tray. |
Also, I really do not like the |
@keianhzo new icons! |
Fixes #1372 #962 #1440 This PR implements the latests Settings spec which also includes the new user agent switch button in the navigation bar.