Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow keyboard to be repositioned #1466

Merged
merged 5 commits into from Jul 31, 2019
Merged

Conversation

MortimerGoro
Copy link
Contributor

Fixes #1146

Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the keyboard with curved windows feels off to me. Especially when moving to the extreme left as the keyboard starts to jitter.

Additionally, It doesn't seem there is a way to reset the keyboard to the default position?

app/src/main/cpp/WidgetPlacement.h Outdated Show resolved Hide resolved
app/src/main/cpp/WidgetPlacement.h Show resolved Hide resolved
app/src/main/cpp/WidgetMover.cpp Outdated Show resolved Hide resolved
@jvonitter
Copy link
Contributor

jvonitter commented Jul 26, 2019

Additionally, It doesn't seem there is a way to reset the keyboard to the default position?

This is by design. Once users move it, they can move it wherever they want including the default position. It should reset once they leave the app.

@bluemarvin
Copy link
Contributor

Additionally, It doesn't seem there is a way to reset the keyboard to the default position?

This is by design. Once users move it, they can move it wherever they want including the default position. It should reset once they leave the app.

The keyboard position is saved between runs and there is no indication when the user has it back in the default position.

Additionally, I notice that you can move the keyboard farther to the right than to the left. This seems like an odd constraint.

@jvonitter
Copy link
Contributor

The keyboard position is saved between runs and there is no indication when the user has it back in the default position.

There's nothing really special about the specific default position. If a user wants it below the awesomebar, they can move it there. If they want it somewhere else, that's ok too. I think whether or not it should reset between runs is something we should consider after we use for a while. If it persists between sessions now, let's see how that feels and switch it if it's bad.

Additionally, I notice that you can move the keyboard farther to the right than to the left. This seems like an odd constraint.

That does seem weird and not intentional.

@MortimerGoro
Copy link
Contributor Author

MortimerGoro commented Jul 30, 2019

PR updated with:

  • Do not save keyboard movement after app is restarted
  • Fix clamping issues and use correct max values based on movement anchor point
  • Address review comments

@MortimerGoro
Copy link
Contributor Author

MortimerGoro commented Jul 30, 2019

I'll improve curved mode movement in a follow-up because I need the math improvements from the multiwindow branch which are not available yet in master.

@bluemarvin bluemarvin merged commit eb20078 into master Jul 31, 2019
@bluemarvin bluemarvin deleted the experimental/keyboard_move branch August 1, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow keyboard to be repositioned
3 participants