Added logs and handle CompletableFutures exception #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
approved these changes
Aug 19, 2019
app/src/common/shared/org/mozilla/vrbrowser/search/suggestions/SuggestionsProvider.java
Show resolved
Hide resolved
| @@ -90,6 +93,11 @@ public void setComparator(Comparator comparator) { | |||
| items.sort(mComparator); | |||
| } | |||
| future.complete(items); | |||
|
|
|||
| }).exceptionally(th -> { | |||
| Log.e(LOGTAG, "Error getting bookmarks suggestions: " + th.getLocalizedMessage()); | |||
There was a problem hiding this comment.
I assume the exceptions do not contain PII? I'm paranoid after all the work it took to clean up FxR.
There was a problem hiding this comment.
Being part of AC I guess they don't, maybe @pocmo can answer that.
There was a problem hiding this comment.
I would hope not but since these API deal with bookmarks and history I could conceive of something get leaked out.
There was a problem hiding this comment.
Since this calls into Kotlin and Rust code of AS libraries we can't really guarantee that at the AC level.
There was a problem hiding this comment.
@keianhzo we should probably make the Logs debug then so they get stripped out for release?
keianhzo
force-pushed
the
wip/noapi_awesome_issue
branch
from
3cb3077
to
c1e5d2e
Compare
|
@bluemarvin updated |
bluemarvin
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1570 Better exception handling for Places related content in suggestions. There seems to be some problem with Places in x86_64 https://mozilla.slack.com/archives/CA4JKKLSG/p1565878585191200 already informed the AC team. In the meantime this helps to show the available content in the awesome bar instead of showing nothing.