Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement multiwindow hover and click border effect. #1603

Merged
merged 2 commits into from Aug 23, 2019
Merged

Implement multiwindow hover and click border effect. #1603

merged 2 commits into from Aug 23, 2019

Conversation

MortimerGoro
Copy link
Contributor

Fixes #1518

@MortimerGoro MortimerGoro force-pushed the hover_border branch 2 times, most recently from 3c65059 to ce4f297 Compare August 22, 2019 11:19
@MortimerGoro
Copy link
Contributor Author

MortimerGoro commented Aug 22, 2019 •
edited

Depth issues fixed, this is ready for testing

bluemarvin
bluemarvin reviewed Aug 23, 2019
View reviewed changes
app/src/main/cpp/WidgetBorder.cpp
normalIndex.push_back(1);
normalIndex.push_back(1);
normalIndex.push_back(1);
normalIndex.push_back(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to do this, a lot, I wonder if we could refactor simple geometry creation out into a factory at some point?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I see you sort of did that already here.

@bluemarvin bluemarvin merged commit 370e4a9 into master Aug 23, 2019
@bluemarvin bluemarvin deleted the hover_border branch August 26, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluemarvin bluemarvin bluemarvin approved these changes

@keianhzo keianhzo Awaiting requested review from keianhzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multiwindow polish- selection/click state
2 participants
@MortimerGoro @bluemarvin