Fixes #2568 Fix issue with shift and multi tapping #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch doesn't work the way I expect. The time out seems to be too long. The double click gets the shift key into caps lock mode. But after that we should just reset since I don't think we need to support a triple click? |
bluemarvin
suggested changes
Jan 23, 2020
keianhzo
force-pushed
the
v9/keyboard_shift_fix
branch
from
848eb41
to
ad114b4
Compare
|
@bluemarvin I've rebased and reduced the multitap timeout. Also I have fixed the keyboard refresh, I've seen that we weren't updating both shift keys when multitapping. I think it's ok if multitapping several times keeps it enabled just in case you click more than two times by mistake. |
bluemarvin
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2568 Fix issue with shift and multi tapping