New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2562 Handle shift switching also for text keys #2685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can still reproduce the issue.
@MortimerGoro can you reproduce this? I can't reproduce it after the fix |
I can't reproduce the issue in latest master: e84c0fb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The keyboard uppercase fix works but the wrong text is triggered when clicking Å (it adds a lowercase å, not the same one shown in the keyboard)
@keianhzo I can reproduce the original problem in master but not in this branch
@MortimerGoro what are your STR? I was able to reproduce it 100% at first but now I can't. |
@bluemarvin STR:
|
@MortimerGoro Using your STR, this patch seems to work for me. I am able to reproduce the issue on master also. |
Actually, the problem I'm seeing is with the english keyboard, long pressing on the |
fce3826
to
e41232b
Compare
@bluemarvin yep, that's a bug. I've pushed a fix. I've also made the overlays to be dismissed in the back button is pressed if they are opened, feels more natural that closing the whole keyboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MortimerGoro This patch appears to work for me.
Fixes #2562 Handle shift switching also for text keys