Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2562 Handle shift switching also for text keys #2685

Merged
merged 3 commits into from Feb 11, 2020

Conversation

keianhzo
Copy link
Collaborator

Fixes #2562 Handle shift switching also for text keys

@keianhzo keianhzo self-assigned this Jan 20, 2020
@keianhzo keianhzo added this to the #9 polish milestone Jan 20, 2020
Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still reproduce the issue.

@keianhzo
Copy link
Collaborator Author

keianhzo commented Feb 3, 2020

@MortimerGoro can you reproduce this? I can't reproduce it after the fix

@bluemarvin
Copy link
Contributor

I can't reproduce the issue in latest master: e84c0fb

Copy link
Contributor

@MortimerGoro MortimerGoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keyboard uppercase fix works but the wrong text is triggered when clicking Å (it adds a lowercase å, not the same one shown in the keyboard)

@keianhzo I can reproduce the original problem in master but not in this branch

@bluemarvin
Copy link
Contributor

@MortimerGoro what are your STR? I was able to reproduce it 100% at first but now I can't.

@MortimerGoro
Copy link
Contributor

@bluemarvin STR:

  • Open Swedish keyboard
  • Click left or right shit to make the keyboard uppercase
  • Click the Å letter
  • The keyboard is still uppercase

@bluemarvin
Copy link
Contributor

@MortimerGoro Using your STR, this patch seems to work for me. I am able to reproduce the issue on master also.

@bluemarvin
Copy link
Contributor

Actually, the problem I'm seeing is with the english keyboard, long pressing on the A key with shift pressed, clicking Å does not return the keyboard to lower case. I see this with this patch applied.

@keianhzo
Copy link
Collaborator Author

keianhzo commented Feb 7, 2020

@bluemarvin yep, that's a bug. I've pushed a fix. I've also made the overlays to be dismissed in the back button is pressed if they are opened, feels more natural that closing the whole keyboard.

Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MortimerGoro This patch appears to work for me.

@MortimerGoro MortimerGoro merged commit 2933730 into master Feb 11, 2020
@MortimerGoro MortimerGoro deleted the v9/shift_text_keys branch February 11, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Keyboard] The keyboard is not switched back to lowercases when clicking the "Å" key
3 participants