Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support vrb ProgramFactory #2773

Merged
merged 2 commits into from Feb 12, 2020
Merged

Support vrb ProgramFactory #2773

merged 2 commits into from Feb 12, 2020

Conversation

bluemarvin
Copy link
Contributor

No description provided.

@bluemarvin bluemarvin self-assigned this Feb 10, 2020
@bluemarvin bluemarvin changed the title bump to newer version of vrb Support vrb ProgramFactory Feb 10, 2020
@bluemarvin bluemarvin force-pushed the shader-factory branch 3 times, most recently from af4712b to 26a7867 Compare February 11, 2020 16:23
@bluemarvin bluemarvin mentioned this pull request Feb 12, 2020
Open
MortimerGoro
MortimerGoro reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@MortimerGoro MortimerGoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading the shader in a separate thread works great. But I found the border is now rendered on top of the keyboard.

@MortimerGoro MortimerGoro merged commit 37ab021 into master Feb 12, 2020
@MortimerGoro MortimerGoro deleted the shader-factory branch February 12, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MortimerGoro MortimerGoro MortimerGoro approved these changes

Assignees

@bluemarvin bluemarvin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bluemarvin @MortimerGoro