Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The YouTube layout changes after closing and reopening/restarting the app #2883

Closed
heres-maria-sv-inactive opened this issue Feb 27, 2020 · 5 comments · Fixed by #3364
Closed
Assignees
Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression Youtube Youtube related issue
Milestone

Comments

@heres-maria-sv-inactive

[Affected Versions]:

  • Firefox Reality version 9 RC4 (c64365e)

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus Plus - Android 7.1.2
  • Pico Neo 2 - Android 8.1.0

[Prerequisites]:

  • The headset is turned on and the browser is open.

[Steps to reproduce]:

  1. Go to YouTube.
  2. Change a setting that causes a restart prompt (e.g. Display -> DPI).
  3. Choose the “Restart Now” option.
  4. Observe the YouTube layout.

[Expected results]:

  • The layout remains the same after restarting.

[Actual results]:

  • The layout completely changes after restarting.

[Notes]:

@heres-maria-sv-inactive heres-maria-sv-inactive added regression [QA]:Normal issue Label for QA to mark normal issues logged labels Feb 27, 2020
@bluemarvin
Copy link
Contributor

You can't change the DPI and not affect the layout. If I switch between multi processing on and off which requires a restart, I don't see this issue.

@bluemarvin
Copy link
Contributor

We should remove most of the display settings as users should not be changing them.

@heres-maria-sv-inactive
Copy link
Author

@bluemarvin I looked into this a bit more and it seems this bug is not reproducible with Multiprocess turned on.

With "Enable Multiprocess" turned off this bug is reproducible for the developer settings that require a restart ("Enable Debug Logging" and "Enable UI Harware Acceleration") as well.

With this setting on, none of the setting restarts, nor closing the app as described in the second note of the original report, led to the faulty behavior.

Switching from one state of the setting to the other (starting with multiprocess off) will not reproduce the issue (though the site will display a blue message twice about being redirected to the desktop site).
But starting with "Enable Multiprocess" on and then turning it off will cause this behavior for the first time, after which the bug is not reproducible due to turning the setting on.

@bluemarvin
Copy link
Contributor

If this is only reproducible when multiprocess is turned off then I don't know that it will get fixed. The multiprocess option will be removed in v10 as disabling multiprocess is just not being supported in GeckoView.

@bluemarvin bluemarvin added this to the #10 features milestone Mar 9, 2020
@bluemarvin bluemarvin added the Youtube Youtube related issue label Mar 18, 2020
@bluemarvin bluemarvin modified the milestones: #10 features, #11 polish Mar 18, 2020
@keianhzo keianhzo self-assigned this May 11, 2020
bluemarvin pushed a commit that referenced this issue May 18, 2020
* Ensure webexts are loaded when restoring sessions

* Update to new webextensions API

* Restore sessions even if the extensions loading fails.
bluemarvin pushed a commit that referenced this issue May 18, 2020
* Ensure webexts are loaded when restoring sessions

* Update to new webextensions API

* Restore sessions even if the extensions loading fails.
@Softvision-RemusDranca
Copy link

I have verified this issue and it's no longer reproducible using Firefox Reality version 11-141402320 (eda7d95). Now, the same layout is displayed for the YouTube website after closing and reopening/restarting the app.

Tested on HTC Vive Focus (Android 7.1.2) and Oculus Quest (Android 7.1.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression Youtube Youtube related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants