Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move accounts initialization to Activity onCreate #2926

Merged
merged 2 commits into from Mar 5, 2020
Merged

Move accounts initialization to Activity onCreate #2926

merged 2 commits into from Mar 5, 2020

Conversation

MortimerGoro
Copy link
Contributor

No description provided.

@MortimerGoro MortimerGoro self-assigned this Mar 5, 2020
@keianhzo keianhzo requested a review from daoshengmu March 5, 2020 19:35
daoshengmu
daoshengmu approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@daoshengmu daoshengmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. there is a ni, please change the commit msg to be onActivityCreate instead of onCreate.

@MortimerGoro MortimerGoro merged commit 9688e63 into master Mar 5, 2020
@MortimerGoro MortimerGoro deleted the v10/accounts_on_create branch March 5, 2020 19:44
bluemarvin pushed a commit that referenced this pull request Mar 5, 2020
@MortimerGoro @bluemarvin
Move accounts initialization to Activity onCreate (#2926)
9350b40 
* Move accounts initialization to onActivityCreate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keianhzo keianhzo keianhzo approved these changes

@daoshengmu daoshengmu daoshengmu approved these changes

Assignees

@MortimerGoro MortimerGoro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MortimerGoro @keianhzo @daoshengmu