Pico Gaze Mode support #2959
Merged
Pico Gaze Mode support #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
suggested changes
Mar 13, 2020
app/src/picovr/java/org/mozilla/vrbrowser/PlatformActivity.java
Outdated
Show resolved
Hide resolved
|
I've confirmed that if you switch controller to left hand on G2, you get the gaze controller instead in FxR. |
keianhzo
force-pushed
the
v10/gaze_support
branch
from
0059677
to
6d860da
Compare
keianhzo
force-pushed
the
v10/gaze_support
branch
from
6d860da
to
27b57ef
Compare
|
Right, wasn't aware of the second controller for G2 but makes sense seeing the controller settings and the fact that you can switch between left/right modes. I've fixed it. |
keianhzo
force-pushed
the
v10/gaze_support
branch
from
27b57ef
to
36a6519
Compare
|
@bluemarvin Updated |
keianhzo
force-pushed
the
v10/gaze_support
branch
from
4539cbf
to
93426cc
Compare
bluemarvin
approved these changes
Mar 17, 2020
|
@MortimerGoro I'm going to land this so QA has time to test it. Any issues can be filed as a follow-up. |
|
I’ve performed exploratory testing on this new feature using the Pico G2 4K and Pico Neo2 headsets, logged all the issues found and also written test cases to cover the new functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1080 This PR adds support for Pico devices Gaze mode.
Design pending, it will be addressed as a follow up when ready.