Prevent duplicated callSurfaceChanged call when exiting immersive mode #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
reviewed
Mar 13, 2020
Comment on lines
316
to
+317
| mSession.setActive(true); | ||
| if (!SettingsStore.getInstance(getContext()).getLayersEnabled()) { | ||
| if (!SettingsStore.getInstance(getContext()).getLayersEnabled() && !mSession.hasDisplay()) { |
There was a problem hiding this comment.
I wonder if we can just check if the mSession is active and then only call setActive(true) and callSurfaceChanged() if it isn't?
There was a problem hiding this comment.
I think is safer to keep this check. My worry is that other place of code calls SetActive before this method and in that case we would miss the surfaceChanged call
bluemarvin
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2957