Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebXR settings and permission flow #3019

Merged
merged 1 commit into from Mar 23, 2020
Merged

Add WebXR settings and permission flow #3019

merged 1 commit into from Mar 23, 2020

Conversation

MortimerGoro
Copy link
Contributor

Fixes #2062

@MortimerGoro MortimerGoro self-assigned this Mar 20, 2020
This was referenced Mar 20, 2020
Closed
Merged
bluemarvin
bluemarvin approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not show the icon for the content feed but looks good otherwise.

daoshengmu
daoshengmu approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@daoshengmu daoshengmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I notice we need to do mulit-lang support for WebXR permission page. We can open another bug to work on it.

@bluemarvin
Copy link
Contributor

LGTM although I notice we need to do mulit-lang support for WebXR permission page. We can open another bug to work on it.

What do you mean by multi-lang? The localization happens automatically after the PR lands.

@daoshengmu
Copy link
Contributor

LGTM although I notice we need to do mulit-lang support for WebXR permission page. We can open another bug to work on it.

What do you mean by multi-lang? The localization happens automatically after the PR lands.

Yep. That's what I mean. It would be great to have the localization automatically.

@bluemarvin
Copy link
Contributor

Hiding the icon for the feed can probably be a follow up.

keianhzo
keianhzo approved these changes Mar 23, 2020
View reviewed changes
Copy link
Collaborator

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a window opened with a webxr blocked site and you clear the blocked sites in settings, the URL bar is not updated and the site is not reloaded.

I'm going to land and leave this as a follow up.

@keianhzo keianhzo merged commit d6079e9 into master Mar 23, 2020
@keianhzo keianhzo deleted the v10/webxr_settings branch March 23, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluemarvin bluemarvin bluemarvin approved these changes

@keianhzo keianhzo keianhzo approved these changes

@daoshengmu daoshengmu daoshengmu approved these changes

Assignees

@MortimerGoro MortimerGoro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings for WebXR
4 participants
@MortimerGoro @bluemarvin @daoshengmu @keianhzo