Reload WebXR sites when settings are changed #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
approved these changes
Mar 23, 2020
| @@ -323,6 +320,9 @@ private void setWebXR(boolean value, boolean doApply) { | |||
|
|
|||
| if (doApply) { | |||
| SettingsStore.getInstance(getContext()).setWebXREnabled(value); | |||
| for (WindowWidget window: mWidgetManager.getWindows().getCurrentWindows()) { | |||
| window.getSession().reload(GeckoSession.LOAD_FLAGS_NONE); | |||
There was a problem hiding this comment.
Should probably be using GeckoSession.LOAD_FLAGS_BYPASS_CACHE as it has been fixed in GV.
| for (WindowWidget window: mWidgetManager.getWindows().getCurrentWindows()) { | ||
| Session session = window.getSession(); | ||
| if (aHost.equalsIgnoreCase(UrlUtils.getHost(session.getCurrentUri()))) { | ||
| session.reload(GeckoSession.LOAD_FLAGS_NONE); |
There was a problem hiding this comment.
And here too should use GeckoSession.LOAD_FLAGS_BYPASS_CACHE
MortimerGoro
force-pushed
the
v10/webxr_settings_reload
branch
from
134d1f3
to
7f95037
Compare
keianhzo
requested changes
Mar 24, 2020
There was a problem hiding this comment.
If you have the same site opened in two windows and Enable/Disable the WebXR status from the URL button, the other window is not refreshed.
Also related, if you have the same site opened in different windows and change the WebXR state in one of them the WebXR icon is not updated when the other window is focused.
|
@keianhzo Done |
|
@MortimerGoro I don't see the items from my last comment fixed, maybe it's not pushed? |
|
@MortimerGoro I see this fixed in the other PR so it's ok. |
keianhzo
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.