Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up WebXR Room Scale sizes #3065

Merged
merged 1 commit into from Mar 27, 2020
Merged

Set up WebXR Room Scale sizes #3065

merged 1 commit into from Mar 27, 2020

Conversation

MortimerGoro
Copy link
Contributor

No description provided.

@MortimerGoro MortimerGoro self-assigned this Mar 27, 2020
bluemarvin
bluemarvin suggested changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to set Cap_StageParameters if we are passing in stage size?

@bluemarvin
Copy link
Contributor

I think we need to set Cap_StageParameters if we are passing in stage size?

I see we are already setting it.

bluemarvin
bluemarvin approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume Pico doesn't support this in the API yet?

@bluemarvin bluemarvin merged commit 28b0362 into master Mar 27, 2020
@bluemarvin bluemarvin deleted the v10/stage_parameters branch March 27, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluemarvin bluemarvin bluemarvin approved these changes

Assignees

@MortimerGoro MortimerGoro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MortimerGoro @bluemarvin