Fix WebXR quick permission regression. Unify permission messages. #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortimerGoro
force-pushed
the
v10/webxr_permission_fix
branch
from
89bd2cf
to
cfadb31
Compare
MortimerGoro
changed the title
bluemarvin
approved these changes
Mar 30, 2020
flodolo
reviewed
Mar 30, 2020
| @@ -1453,7 +1453,7 @@ the Select` button. When clicked it closes all the previously selected tabs --> | |||
|
|
|||
| <!-- This string is displayed in the title of the quick WebXR blocking dialog, accessed from the VR icon in the URL bar. | |||
| '%1$s' will be replaced at runtime with the app's name. --> | |||
| <string name="webxr_block_dialog_message">‘%1$s’ wants to access WebXR API</string> | |||
| <string name="webxr_permission_dialog_message">WebXR is %1$s for this site. (<a href="%2$s">Learn More</a>)</string> | |||
There was a problem hiding this comment.
Two questions:
- What does
WebXR is Firefox for this site.mean? Because that's what the comment implies - Is the HTML supposed to look like this?
There was a problem hiding this comment.
Ups, the comment is wrong. The real text will be: WebXR is "on/off" for this site
There was a problem hiding this comment.
And where do "ON" and "OFF" come from? Note that they're adjectives, so they need to be adapted to the name, and you can't reuse generic ones.
There was a problem hiding this comment.
Any update on this? We can't expose for localization any strings until this is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.