Implement WebXR Interstitial #3136

MortimerGoro · 2020-04-08T18:10:10Z

Fixes #1966 Fixes #3123

MortimerGoro · 2020-04-08T18:11:06Z

The spinner animation is not the final one, @keianhzo is working on the shapeshifter exported version

daoshengmu · 2020-04-08T18:21:42Z

There is a build fail on this merge:

/opt/FirefoxReality/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WebXRInterstitialController.java:15: error: cannot find symbol
    private WebxrInterstitialControllerBinding mBinding;

MortimerGoro · 2020-04-08T19:01:02Z

There is a build fail on this merge:

/opt/FirefoxReality/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WebXRInterstitialController.java:15: error: cannot find symbol
    private WebxrInterstitialControllerBinding mBinding;

Fixed

daoshengmu · 2020-04-08T22:28:30Z

I notice the controller icons only be shown when entering the immersive mode at the 1st time. Is it what we want?

MortimerGoro · 2020-04-08T23:51:15Z

For now it’s displayed for 3 seconds the first time you enter immersive (on each app restart)
I don’t like forcing it every EnterVR.

After trying it I think it would be good to wait for a user click to dismiss the how-to information, and remove the forced time. IMO:

The first time you go to WebXR show the how-to-exit information. Dismiss after a click, not time based. We don’t know how long takes for a user to process the info and find the button.
Do not show the spinner at the same time, it distracts from reading the how-to
Show the spinner only in the next EnterVR for the whole session

Thoughts?

bluemarvin

If three window are open, the controllers are drawn behind the spinner:

bluemarvin · 2020-04-09T00:38:49Z

For now it’s displayed for 3 seconds the first time you enter immersive (on each app restart)
I don’t like forcing it every EnterVR.

After trying it I think it would be good to wait for a user click to dismiss the how-to information, and remove the forced time. IMO:
* The first time you go to WebXR show the how-to-exit information. Dismiss after a click, not time based. We don’t know how long takes for a user to process the info and find the button.

* Do not show the spinner at the same time, it distracts from reading the how-to

* Show the spinner only in the next EnterVR for the whole session
Thoughts?

I think this is a good approach. I think the controller images could be a little bigger maybe?

daoshengmu · 2020-04-09T00:49:51Z

For now it’s displayed for 3 seconds the first time you enter immersive (on each app restart)
I don’t like forcing it every EnterVR.

After trying it I think it would be good to wait for a user click to dismiss the how-to information, and remove the forced time. IMO:

The first time you go to WebXR show the how-to-exit information. Dismiss after a click, not time based. We don’t know how long takes for a user to process the info and find the button.

Do not show the spinner at the same time, it distracts from reading the how-to

Show the spinner only in the next EnterVR for the whole session

Thoughts?

I feel we can remove the spinner if we are showing the how-to-exit information, the spinner sometimes catches my attention other than the how-to-exit. However, if users end the information icon, WebXR pages are still loading. We should still show the spinner instead.

Make the controller image bigger can let me see the words more easy. I also feel if we already allow users to press a button to end the how-to-exit information, maybe longer time like 5 secs would be great for user have more time to understand it.

bluemarvin

I think we can remove spinners_v3.obj, spinners_v3.mtl, and spinners_v3.ktx.

bluemarvin · 2020-04-09T17:26:39Z

app/src/common/shared/org/mozilla/vrbrowser/utils/DeviceType.java

+            case ViveFocusPlus:
+                name = "Vive Focus Plus";
+                break;


Do we need a ViveFocus also?

bluemarvin · 2020-04-09T17:34:10Z

app/src/main/cpp/BrowserWorld.cpp

  m.drawHandler = [=](device::Eye eye) {
-    DrawLoadingAnimation(eye);
+      DrawWebXRInterstitial(eye);


nit: Looks like there are two extra spaces added?

bluemarvin

I think we still want to have support for the regular Focus controller.

bluemarvin · 2020-04-09T19:04:43Z

app/src/common/shared/org/mozilla/vrbrowser/utils/DeviceType.java

 import org.mozilla.vrbrowser.BuildConfig;

 public class DeviceType {
    // These values need to match those in Device.h
+    @IntDef(value = { Unknown, OculusGo, OculusQuest, ViveFocusPlus, PicoNeo2, PicoG2 })


It looks like Device.h needs to be updated?

We need ViveFocus as well

daoshengmu · 2020-04-09T19:05:23Z

Do we have an alpha blending problem on the spinner image? I can see its rectangle background when we are going to end the animation.

MortimerGoro · 2020-04-09T19:40:07Z

@daoshengmu @bluemarvin I implemented the flow we talked about. Let me know what you think. Feel free to change the new text

daoshengmu · 2020-04-09T20:29:16Z

@daoshengmu @bluemarvin I implemented the flow we talked about. Let me know what you think. Feel free to change the new text

It seems like pressing squeeze btns on Quest can't exit the how-to-exit page.

MortimerGoro · 2020-04-09T21:05:53Z

@daoshengmu @bluemarvin I implemented the flow we talked about. Let me know what you think. Feel free to change the new text

It seems like pressing squeeze btns on Quest can't exit the how-to-exit page.

Fixed

MortimerGoro · 2020-04-09T21:08:14Z

Do we have an alpha blending problem on the spinner image? I can see its rectangle background when we are going to end the animation.

I noticed that too but it seems a driver bug. It only happens with the first layer displayed on a black background. If I change the order the alpha blending moves to the first layer rendered. I'll look into it next week, we can address that as a follow-up

daoshengmu · 2020-04-09T21:16:49Z

app/src/oculusvr/cpp/DeviceDelegateOculusVR.cpp

-
-        // This is always false in Oculus Browser.
-        const bool thumbRest = false;
-        controller->SetButtonState(controllerState.index, ControllerDelegate::BUTTON_OTHERS, 5, thumbRest, thumbRest);
      } else {


It looks odd to me. This is thumbRest instead of the grip button, and thumbRest is always false. If thumbRest will cause problems to you, Neo2 will have it too because it also has thumbRest.

You can remove this commit now. I already gave a fix at #2521 by defining a new btn state BUTTON_SQUEEZE. That makes sense for us to use it in app.

MortimerGoro requested review from bluemarvin, keianhzo and daoshengmu April 8, 2020 18:10

MortimerGoro self-assigned this Apr 8, 2020

MortimerGoro force-pushed the v10/webxr_interstitial branch from f786c4c to 6f7a696 Compare April 8, 2020 18:56

bluemarvin suggested changes Apr 9, 2020

View reviewed changes

MortimerGoro force-pushed the v10/webxr_interstitial branch 5 times, most recently from e3943e9 to b1db18a Compare April 9, 2020 17:09

bluemarvin reviewed Apr 9, 2020

View reviewed changes

bluemarvin approved these changes Apr 9, 2020

View reviewed changes

bluemarvin reviewed Apr 9, 2020

View reviewed changes

bluemarvin mentioned this pull request Apr 9, 2020

WebXR gamepad module support. #2521

Merged

daoshengmu approved these changes Apr 9, 2020

View reviewed changes

daoshengmu reviewed Apr 9, 2020

View reviewed changes

MortimerGoro force-pushed the v10/webxr_interstitial branch from 95115f6 to a94ddbf Compare April 16, 2020 18:20

MortimerGoro force-pushed the v10/webxr_interstitial branch from a94ddbf to 6452dc9 Compare April 16, 2020 18:22

MortimerGoro and others added 8 commits April 17, 2020 10:44

Implement WebXR Interstitial

2232ce2

Fix for AnimatedVectorDrawables in Pico devices

d62afa7

Improve layout and flow.

e5875b7

Remove old spinner

b83f37a

Hide controller input until the interstitial is hidden.

9427347

Fix grip button detection in Oculus

3b2def4

Rebase and update to latest spec

6eb53b8

Restore required disabling hw acceleration for voice animation

af1f81d

keianhzo force-pushed the v10/webxr_interstitial branch from 6452dc9 to af1f81d Compare April 17, 2020 08:57

keianhzo approved these changes Apr 17, 2020

View reviewed changes

keianhzo merged commit 93b3f9f into master Apr 17, 2020

keianhzo deleted the v10/webxr_interstitial branch April 17, 2020 08:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement WebXR Interstitial #3136

Implement WebXR Interstitial #3136

MortimerGoro commented Apr 8, 2020 •

edited by keianhzo

MortimerGoro commented Apr 8, 2020

daoshengmu commented Apr 8, 2020

MortimerGoro commented Apr 8, 2020

daoshengmu commented Apr 8, 2020

MortimerGoro commented Apr 8, 2020 •

edited

bluemarvin left a comment

bluemarvin commented Apr 9, 2020

daoshengmu commented Apr 9, 2020 •

edited

bluemarvin left a comment

bluemarvin Apr 9, 2020

bluemarvin Apr 9, 2020

bluemarvin left a comment

bluemarvin Apr 9, 2020

daoshengmu Apr 9, 2020

daoshengmu commented Apr 9, 2020

MortimerGoro commented Apr 9, 2020

daoshengmu commented Apr 9, 2020

MortimerGoro commented Apr 9, 2020

MortimerGoro commented Apr 9, 2020

daoshengmu Apr 9, 2020 •

edited

daoshengmu Apr 9, 2020

Implement WebXR Interstitial #3136

Implement WebXR Interstitial #3136

Conversation

MortimerGoro commented Apr 8, 2020 • edited by keianhzo

MortimerGoro commented Apr 8, 2020

daoshengmu commented Apr 8, 2020

MortimerGoro commented Apr 8, 2020

daoshengmu commented Apr 8, 2020

MortimerGoro commented Apr 8, 2020 • edited

bluemarvin left a comment

Choose a reason for hiding this comment

bluemarvin commented Apr 9, 2020

daoshengmu commented Apr 9, 2020 • edited

bluemarvin left a comment

Choose a reason for hiding this comment

bluemarvin Apr 9, 2020

Choose a reason for hiding this comment

bluemarvin Apr 9, 2020

Choose a reason for hiding this comment

bluemarvin left a comment

Choose a reason for hiding this comment

bluemarvin Apr 9, 2020

Choose a reason for hiding this comment

daoshengmu Apr 9, 2020

Choose a reason for hiding this comment

daoshengmu commented Apr 9, 2020

MortimerGoro commented Apr 9, 2020

daoshengmu commented Apr 9, 2020

MortimerGoro commented Apr 9, 2020

MortimerGoro commented Apr 9, 2020

daoshengmu Apr 9, 2020 • edited

Choose a reason for hiding this comment

daoshengmu Apr 9, 2020

Choose a reason for hiding this comment

MortimerGoro commented Apr 8, 2020 •

edited by keianhzo

MortimerGoro commented Apr 8, 2020 •

edited

daoshengmu commented Apr 9, 2020 •

edited

daoshengmu Apr 9, 2020 •

edited