Insure onLoadRequest only waits for correct number of listeners. #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3157 When GeckoView started short cutting onLoadRequest, the number of Navigation Listeners would be larger when the GeckoRequest was finally processed so the GeckoResult would never get completed and the load would never start.
bluemarvin
force-pushed
the
tab-restore
branch
3 times, most recently
from
f17395a
to
7300f08
Compare
keianhzo
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3157
When GeckoView started short cutting onLoadRequest, the number of
Navigation Listeners would be larger when the GeckoRequest was finally
processed so the GeckoResult would never get completed and the load
would never start.