Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The tray notification for finished downloads is wrongly displayed even when the tray is hidden #3241

Closed
Softvision-RemusDranca opened this issue Apr 24, 2020 · 1 comment · Fixed by #3242
Closed

The tray notification for finished downloads is wrongly displayed even when the tray is hidden #3241

Softvision-RemusDranca opened this issue Apr 24, 2020 · 1 comment · Fixed by #3242
Assignees
@keianhzo
Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
#10 features

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

  • Firefox Reality version 10 RC1 (6db2f60).

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus - Android 7.1.2
  • Pico Neo2 - Android 8.1.0

[Prerequisites]:

  • The Firefox Reality browser is open.

[Steps to reproduce]:

  1. Navigate to a website and download a file.
  2. Open the Downloads page to observe the download progress.
  3. Click the Awesomebar so that the keyboard is displayed.
  4. Wait until the file is downloaded.
  5. Observe if the notification "'name of file' Downloaded" is displayed.

[Expected results]:

  • The notification is not displayed.

[Actual results]:

  • The notification is displayed even if the tray is hidden.

[Notes]:

  • The notification is also displayed while in immerseve/theater mode.
  • Attached is a screen recording of the issue: link.
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Normal issue Label for QA to mark normal issues logged label Apr 24, 2020
@keianhzo keianhzo self-assigned this Apr 24, 2020
@keianhzo keianhzo added this to the #10 features milestone Apr 24, 2020
@keianhzo keianhzo mentioned this issue Apr 24, 2020
Merged
bluemarvin pushed a commit that referenced this issue Apr 24, 2020
@keianhzo
Fixes #3241 Fixes #3240 Download fixes (#3242)
17a313b 
* Remove unnecessary cursor loop

* Fixed typo

* Report all pending downloads number and arithmetic exceptions

* Fix deleting the downloaded file

* Only show Tray notifications if tray is visible

* Remove unused string parameter

* Switch to empty list instantly when removing all downloads

* Better diff handling
@Softvision-RemusDranca
Copy link
Author

I have verified this issue and it's no longer reproducible with the Firefox Reality version 10 RC2 (17a313b). The tray notification for finished downloads is no longer displayed when the tray is hidden.

Tested on HTC Vive Focus (Android 7.1.2), Oculus Quest (Android 7.1.1) and Pico Neo 2 (Android - 8.1.0) devices.

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keianhzo keianhzo

Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
#10 features
Development

Successfully merging a pull request may close this issue.

Fixes #3241 Fixes #3240 Download fixes MozillaReality/FirefoxReality
2 participants
@keianhzo @Softvision-RemusDranca