Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The WebXR, DRM and Pop-UP blocked buttons are not displayed in the Awesomebar if ETP is turned off from settings #3291

Closed
Softvision-RemusDranca opened this issue Apr 30, 2020 · 1 comment · Fixed by #3292
Closed

The WebXR, DRM and Pop-UP blocked buttons are not displayed in the Awesomebar if ETP is turned off from settings #3291

Softvision-RemusDranca opened this issue Apr 30, 2020 · 1 comment · Fixed by #3292
Assignees
@keianhzo
Labels
in progress [QA]:Major issue Label for QA to mark major issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
#10 features

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

  • Firefox Reality version 10 RC3 (5b346b6).

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus - Android 7.1.2
  • Pico Neo 2 - Android - 8.1.0

[Prerequisites]:

  • The headset is turned on and the app is opened.

[Steps to reproduce]:

  1. Open the Privacy and Security card from Settings.
  2. Set the ETP option to Off.
  3. Open for example this page from krpano website.
  4. Observe if the WebXR icon is displayed in the Awesomebar.

[Expected results]:

  • The icon is displayed.

[Actual results]:

  • The icon is not displayed.

[Notes]:

  • This issue is also reproducible with the DRM and Pop-UP blocked buttons.
  • The "Pop-UP blocking notification is displayed even if the button is not.
  • The issue involving the DRM button is not reproducible on Pico devices since DRM content is not supported.
  • The buttons are displayed after resuming the app or after refocusing the affected window, if multiple windows are opened.
  • Attached is a screen recording of the issue: link.
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Major issue Label for QA to mark major issues logged label Apr 30, 2020
@keianhzo keianhzo self-assigned this Apr 30, 2020
@keianhzo keianhzo mentioned this issue Apr 30, 2020
Merged
@keianhzo keianhzo modified the milestones: #11 polish, #10 features Apr 30, 2020
bluemarvin pushed a commit that referenced this issue Apr 30, 2020
@keianhzo
Fixes #3291 Update URL bar icons visibility based on permissions state (
c9f36b7 
#3292)

* Update url bar icons visibility based on state change

* Update the URL bar before the location change.
@Softvision-RemusDranca
Copy link
Author

I have verified this issue and it's no longer reproducible with the Firefox Reality version 10 RC4 (2999129). The WebXR, DRM and Pop-UP blocked buttons are now displayed in the Awesomebar if ETP is turned off from settings.

Tested on HTC Vive Focus (Android 7.1.2), Oculus Quest (Android 7.1.1), and Pico Neo 2 (Android - 8.1.0) devices.

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keianhzo keianhzo

Labels
in progress [QA]:Major issue Label for QA to mark major issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
#10 features
Development

Successfully merging a pull request may close this issue.

Fixes #3291 Update URL bar icons visibility based on permissions state MozillaReality/FirefoxReality
2 participants
@keianhzo @Softvision-RemusDranca