Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for available apps when opening a file #3352

Merged
merged 1 commit into from May 19, 2020
Merged

Conversation

keianhzo
Copy link
Collaborator

@keianhzo keianhzo commented May 8, 2020

Check for available apps when opening a file otherwise we just show that the file is unsupported. It's not easy to test because of the lack of utilities in most platforms at the moment. It can be tested with:

  • 3GP, TIFF in Oculus
  • 3GP in Pico

@keianhzo keianhzo self-assigned this May 8, 2020
@keianhzo keianhzo requested a review from bluemarvin May 8, 2020 14:49
@keianhzo keianhzo added this to the #11 polish milestone May 11, 2020
@bluemarvin
Copy link
Contributor

Looks like this depends on #3297 and needs to be rebased?

@bluemarvin
Copy link
Contributor

I wasn't able to ever get the built in app to play any of the video I downloaded on the Pico G2. Additionally, all video's I downloaded from https://www.appsloveworld.com/download-sample-3gp-video-file-for-testing/ failed to download yet the download works on desktop. Downloaded videos that didn't play were from https://filesamples.com/formats/3gp

@keianhzo
Copy link
Collaborator Author

@bluemarvin Fixed rebase issues.

Regarding the system app playback errors, I think there not much we can do about it other than never allowing to open with an external app.

The download failure, the Android DownloadManager fails with Stop requested with status TOO_MANY_REDIRECTS: Too many redirects but I couldn't find much info about it, might be system limitation.

@bluemarvin bluemarvin merged commit 4abe405 into master May 19, 2020
@bluemarvin bluemarvin deleted the v11/downloads_open branch May 19, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants