Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow prefs to be set by extras in debug builds #3353

Merged
merged 1 commit into from May 8, 2020
Merged

Only allow prefs to be set by extras in debug builds #3353

merged 1 commit into from May 8, 2020

Conversation

bluemarvin
Copy link
Contributor

No description provided.

@bluemarvin bluemarvin added this to the #10 features milestone May 8, 2020
@bluemarvin bluemarvin self-assigned this May 8, 2020
@bluemarvin
Copy link
Contributor Author

Fixes #3348

@bluemarvin bluemarvin linked an issue May 8, 2020 that may be closed by this pull request
Remove dom.vr.require-gesture: false on release #3348
Closed
@bluemarvin bluemarvin merged commit e84d3c9 into master May 8, 2020
@bluemarvin bluemarvin deleted the extras-debug branch May 8, 2020 16:49
@fernandojsg
Copy link

I agree on the point of disabling all the prefs by default letting the user to set them if they want, but why can you also set them when running the app through an adb command, it could be useful to have access to that or at least having just a pref that you could accept other prefs by command line?

@bluemarvin
Copy link
Contributor Author

I agree on the point of disabling all the prefs by default letting the user to set them if they want, but why can you also set them when running the app through an adb command, it could be useful to have access to that or at least having just a pref that you could accept other prefs by command line?

We need a quick fix for v10. I filed this as follow up #3354

@fernandojsg
Copy link

OK, it makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MortimerGoro MortimerGoro MortimerGoro approved these changes

Assignees

@bluemarvin bluemarvin

Labels
None yet
Projects
None yet
Milestone
#10 features
Development

Successfully merging this pull request may close these issues.

Remove dom.vr.require-gesture: false on release
3 participants
@bluemarvin @fernandojsg @MortimerGoro