Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not override quality on click #3461

Merged
merged 1 commit into from Jun 4, 2020
Merged

Do not override quality on click #3461

merged 1 commit into from Jun 4, 2020

Conversation

keianhzo
Copy link
Collaborator

@keianhzo keianhzo commented Jun 4, 2020

Fixes #2946 (comment)

Quality was being overridden as part of the player fixes when the player settings were clicked.

@keianhzo keianhzo self-assigned this Jun 4, 2020
@keianhzo keianhzo requested a review from bluemarvin June 4, 2020 09:17
@keianhzo keianhzo mentioned this pull request Jun 4, 2020
Closed
@bluemarvin bluemarvin added this to the #11 polish milestone Jun 4, 2020
@bluemarvin bluemarvin merged commit 23bc8e7 into master Jun 4, 2020
@bluemarvin bluemarvin deleted the v11/youtube_quality_override branch June 4, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluemarvin bluemarvin bluemarvin approved these changes

Assignees

@keianhzo keianhzo

Labels
None yet
Projects
None yet
Milestone
#11 polish
Development

Successfully merging this pull request may close these issues.

[Youtube][Intermittent] A different resolution is set for videos either too high or too low
2 participants
@keianhzo @bluemarvin