Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert master branch to use main #3559

Merged
merged 1 commit into from Jun 30, 2020
Merged

Convert master branch to use main #3559

merged 1 commit into from Jun 30, 2020

Conversation

bluemarvin
Copy link
Contributor

No description provided.

@bluemarvin bluemarvin added this to the #12 features milestone Jun 25, 2020
@bluemarvin bluemarvin requested a review from keianhzo June 25, 2020 21:07
@bluemarvin bluemarvin self-assigned this Jun 25, 2020
@bluemarvin
Copy link
Contributor Author

We don't want to land this until the main branch is created and set as the default and the index path has been updated.

@emstanley emstanley added this to FxR 12 - August 31, 2020 in Milestone Planning Jun 25, 2020
@emstanley emstanley added this to To do in FxR v12 Jun 25, 2020
@keianhzo
Copy link
Collaborator

keianhzo commented Jun 30, 2020 •
edited

@Pike @Delphine Do you need to do any changes to the automation bot for the automatic PRs to work properly with the new main branch?

keianhzo
keianhzo approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@keianhzo keianhzo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM My only concern is the above comment.

FxR v12 automation moved this from To do to Reviewer approved Jun 30, 2020
@Pike
Copy link
Contributor

Pike commented Jun 30, 2020

I guess this is best answered by @tomprince , but the answer is "yes".

One thing we need to change for sure is https://github.com/mozilla-l10n/android-l10n/blob/0caabe42a3638077cda59b3ba2f10d5cf0b5c2b1/config.toml#L19

@bluemarvin bluemarvin changed the base branch from master to main June 30, 2020 15:54
@bluemarvin bluemarvin marked this pull request as ready for review June 30, 2020 15:55
@bluemarvin bluemarvin merged commit a2ff180 into main Jun 30, 2020
FxR v12 automation moved this from Reviewer approved to Done Jun 30, 2020
@bluemarvin bluemarvin deleted the to-main branch June 30, 2020 15:56
@bluemarvin bluemarvin mentioned this pull request Jul 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keianhzo keianhzo keianhzo approved these changes

Assignees

@bluemarvin bluemarvin

Labels
None yet
Projects
FxR v12
  
Done
Milestone Planning
FxR 12 - August 31, 2020
Milestone
#12 features
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bluemarvin @keianhzo @Pike