Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not call addSession in SessionStore.onStackSession() #3682

Merged
merged 1 commit into from Jul 15, 2020
Merged

Do not call addSession in SessionStore.onStackSession() #3682

merged 1 commit into from Jul 15, 2020

Conversation

MortimerGoro
Copy link
Contributor

@MortimerGoro MortimerGoro commented Jul 15, 2020 •
edited

Fixes #3681

It's already called in createSession

@MortimerGoro MortimerGoro added the Uplift PR that needs to be uplifted. label Jul 15, 2020
@MortimerGoro MortimerGoro self-assigned this Jul 15, 2020
keianhzo
keianhzo approved these changes Jul 15, 2020
View reviewed changes
Copy link
Collaborator

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I just realized that there is an issue in the ordering of the unlinking/removing, we should unlink before the session is removed. I'll fix that in a follow up

@keianhzo keianhzo merged commit 3786163 into main Jul 15, 2020
@keianhzo keianhzo deleted the v11/on_Stack branch July 15, 2020 12:35
@bluemarvin bluemarvin removed the Uplift PR that needs to be uplifted. label Jul 15, 2020
bluemarvin pushed a commit that referenced this pull request Jul 15, 2020
@MortimerGoro @bluemarvin
Do not call addSession in SessionStore.onStackSession() (#3682)
feabcb4 
Fixes #3681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keianhzo keianhzo keianhzo approved these changes

@bluemarvin bluemarvin Awaiting requested review from bluemarvin

Assignees

@MortimerGoro MortimerGoro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The app crashes when a new tab is open by clicking a link or by pop-up-
3 participants
@MortimerGoro @keianhzo @bluemarvin