Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the unlinking/removing sessions order #3683

Merged
merged 1 commit into from Jul 15, 2020
Merged

Fix the unlinking/removing sessions order #3683

merged 1 commit into from Jul 15, 2020

Conversation

keianhzo
Copy link
Collaborator

We have to unlink when closing before removing the session from the BrowserStore.

@keianhzo keianhzo self-assigned this Jul 15, 2020
@keianhzo keianhzo added the Uplift PR that needs to be uplifted. label Jul 15, 2020
@MortimerGoro MortimerGoro merged commit 0c66e95 into main Jul 15, 2020
@MortimerGoro MortimerGoro deleted the v11/session_unlinking_order branch July 15, 2020 12:53
@bluemarvin bluemarvin removed the Uplift PR that needs to be uplifted. label Jul 15, 2020
bluemarvin pushed a commit that referenced this pull request Jul 15, 2020
@keianhzo @bluemarvin
Fix the unlinking/removing sessions order (#3683)
7e8fa9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MortimerGoro MortimerGoro MortimerGoro approved these changes

Assignees

@keianhzo keianhzo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keianhzo @MortimerGoro @bluemarvin