Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oculus VR multiple controllers support #886

Merged
merged 5 commits into from Jan 18, 2019
Merged

Oculus VR multiple controllers support #886

merged 5 commits into from Jan 18, 2019

Conversation

daoshengmu
Copy link
Contributor

@daoshengmu daoshengmu commented Dec 11, 2018 •
edited

In this PR, we would like to support multiple 6DOF controllers in Oculus. I have added this new controller model to the asset folder and help Oculus VR enumerates new controllers at runtime to update controller's status.

Besides, I also expand ExternalVR to provide 6DOF controller experience in WebVR immersive mode. I have verified it would work properly in the examples from http://webvr.info/ and https://hubs.mozilla.com/, it is very close to the quality as Oculus Rift in FF desktop.

@daoshengmu daoshengmu self-assigned this Dec 11, 2018
@daoshengmu daoshengmu force-pushed the oculusMultiControllers branch 2 times, most recently from 60f7157 to c47c731 Compare December 13, 2018 05:54
bluemarvin
bluemarvin reviewed Dec 14, 2018
View reviewed changes
Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We updated to use KTX for textures. There are now instructions for converting. Please update the controller models to use compressed textures.

@daoshengmu
Copy link
Contributor Author

Replaced the model's texture to be KTX.

@daoshengmu
Copy link
Contributor Author

@MortimerGoro @bluemarvin I think it is ready to continue to review.
Thanks.

MortimerGoro
MortimerGoro suggested changes Dec 20, 2018
View reviewed changes
app/src/main/cpp/ExternalVR.cpp Outdated Show resolved Hide resolved
app/src/wavevr/cpp/DeviceDelegateWaveVR.cpp Outdated Show resolved Hide resolved
app/src/oculusvr/cpp/DeviceDelegateOculusVR.cpp Show resolved Hide resolved
@daoshengmu
Copy link
Contributor Author

@MortimerGoro please help review my reply. Thanks!

@daoshengmu
Copy link
Contributor Author

@MortimerGoro I think all the requests are resolved! Thanks.

@daoshengmu
Copy link
Contributor Author

daoshengmu commented Jan 11, 2019 •
edited

The log from Taskcluster is odd. I don't know what's wrong with the server.

A problem occurred configuring project ':samples-sdk-controllerclient'.
> Malformed input or input contains unmappable characters: /opt/FirefoxReality/.git/modules/gvr-android-sdk/refs/tags/v???1.190.0???```

@MortimerGoro
Copy link
Contributor

@daoshengmu have you tried a rebase?

@daoshengmu daoshengmu mentioned this pull request Jan 15, 2019
Closed
@daoshengmu
Copy link
Contributor Author

@MortimerGoro I already tried. I also tried to apply my patches with a new branch as #924. @bluemarvin Do you know why Taskcluster's tasks failed recently?

@bluemarvin
Copy link
Contributor

The problem is Google broke the Daydream NDK extract. Trying to find a solution. May have to stop building on automation short term. May need to fork the NDK and fix the gradle files until google gets around to it.

@bluemarvin
Copy link
Contributor

googlevr/gvr-android-sdk#599

@MortimerGoro
Copy link
Contributor

Merging this, the taskcluster issue is not related to this PR

@MortimerGoro MortimerGoro merged commit 0afae0d into MozillaReality:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluemarvin bluemarvin bluemarvin left review comments

@MortimerGoro MortimerGoro MortimerGoro approved these changes

Assignees

@daoshengmu daoshengmu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daoshengmu @MortimerGoro @bluemarvin