Fix loading icon stuck on startup #897
Conversation
MortimerGoro
changed the title
There was a problem hiding this comment.
I'm familiar with the bug described in #855, but I haven't been able to capture it on video/screenshot.
I've tried quite a few times on master vs. this branch, loading_icon.
The last time I did reproduce it in this branch, loading_icon, was with loading a YouTube video:
adb shell am start -n "com.oculus.vrshell/.MainActivity" -d apk://com.oculus.browser -e uri "https://www.youtube.com/watch?v=sPyAQQklc1s"
I'd say merge, but I don't think this fixes the issues with the circle-loading throbber per #855.
MortimerGoro
force-pushed
the
loading_icon
branch
from
73dad9d
to
e330fb6
Compare
|
I was able to reproduce the problems in this branch using the youtube as the default URL. After more research found that the problem is caused on Android pause/resume events. We need to pause and resume the animation view on those situations |
|
@MortimerGoro let me know when you're ready for a re-review. thank you for taking a deep dive here 👍 |
|
@cvan it's ready for re-review |
|
I'm going to merge this one. Create some follow-up if you find something else |
Fixes #855