Fixes #435 Added support for alert/prompt/confirm #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ready to merge? Are there any specific tests I can try first? |
MortimerGoro
approved these changes
Dec 20, 2018
|
You can test with https://webxr.sh/dialogues.html |
|
Just merge and I’ll test the staging build. |
|
Looks good to me. |
|
@cvan if you find additional issues file followup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435 Added support for alert/text/confirm prompt dialogs. Prompts are now dynamically resizable depending on the content size with a max height limit.
@MortimerGoro I've noticed a glitch when resizing the widget I guess because the size is updated while the widget is still visible. I didn't have time to dig into that so feel free to update the PR or open a follow-up to fix that.