Replace Gamepad id from "Gear VR Controller" to Oculus Go/HTC HTC Vive Focus controllers

[daoshengmu]

Per #812, we should use the same gamepad id, Oculus Go Controller, as other browsers when running in Oculus Go display.

[bluemarvin]

Be aware this was done for compatibility reasons. So make sure changing it doesn't break some of existing immersive web sites.

[philip-lamb]

We should also update the string exposed for the HTC Vive Focus controller. Per aframevr/aframe#3876 (https://github.com/aframevr/aframe/pull/3876/files#diff-0cf01d3ef4445863595ddf0ff798ecfbR11) it should be corrected to 'HTC Vive Focus Controller' at https://github.com/MozillaReality/FirefoxReality/blob/master/app/src/wavevr/cpp/DeviceDelegateWaveVR.cpp#L302 .

[bluemarvin]

For reference: #441

[daoshengmu]

I begin to worry about that will affect content that didn't use A-Frame or didn't follow its latest update. I guess we do need more opinions from @cvan .

[philip-lamb]

I'll log an issue to consider a compatibility setting in the UI. If we continue incorrectly sending Gear VR as the identifier, we'll continue to diverge in webcompat from the Oculus browser. We can potentially sniff older AFrame versions before the Oculus Go controller and HTC Vive Focus controller strings were added.

[cvan]

If we continue incorrectly sending Gear VR as the identifier, we'll continue to diverge in webcompat from the Oculus browser.

I agree that we should report the same Gamepad#id as Oculus Browser does.

We can potentially sniff older AFrame versions before the Oculus Go controller and HTC Vive Focus controller strings were added.

Assuming we can't reach out to the site owners of the more popular A-Frame experiences (e.g., the ones in the Content Feed), ensuring backwards compatibility with older A-Frame versions I don't think is a reasonable expectation.

On a related note, see this comment I made about Gamepad#id in general here:

I've commented on w3c/gamepad#73 (comment). Will update as I do some research on the actual sites possibly impacted by Gamepad#id sniffing.

[cvan]

So as to not break Soundboxing (and likely other WebVR experiences I'm not aware of), we should probably wait before merging this. I've emailed the Soundboxing staff asking them to upgrade to A-Frame version 0.9.0 and to use the oculus-go-controls component (currently they're using only the gearvr-controls component). I'll respond here when I hear a response. Thank you, @daoshengmu!

[MortimerGoro]

Let's wait to merge this until @cvan confirms that the content feed demos are ready

[cvan]

👍 nice work. this looks good to ship.

I haven't found any WebCompat issues in any of the following WebVR experiences I've tested. with your change, these all worked:

• Delight-VR video player (and in fact, the controller mesh graphic is now correctly an Oculus Go controller instead of a Samsung Gear VR controller 👍)
• WITHIN
• PanoMoments (doesn't require a Gamepad)
• Sketchfab (and in fact, the controller mesh graphic is now correctly an Oculus Go controller instead of a Samsung Gear VR controller 👍)
• EFF's Spot the Surveillance (doesn't require a Gamepad)
• Pristine
• Jingle Smash
• Vuppets
• Hallovreen (doesn't require a Gamepad)
• Soundboxing

[MortimerGoro]

@cvan Have you also tested the controller change in HTC Vive focus?