New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting window size oddities #993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we need to rethink the display and max display settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the incorrect size when a width of 800 is set, but not that changing the width still doesn't fix the actual size of the web content pane; it only changes the height (so that the aspect ratio is correct).
I think there is some confusion over what the window size field represent. This is actually the default window size. So when the user clicks the |
I agree that it's confusing. I understand it as the window pixel size for 1x world size: similar to a zooming feature, show more or less pixels in the same world meters size. Should we just remove these settings? What's the use case to have them? |
I think it should at least be renamed. I don't see anything wrong with allowing users to set the default size of a window. |
OK, let's get this change in first and we can consider labelling change separately. |
e09c88e
to
de6a599
Compare
Fixes #990