Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugs in generating wsj0-mix dataset with wv1 && loading model acc… #166

Merged
merged 3 commits into from Jul 10, 2020
Merged

fix bugs in generating wsj0-mix dataset with wv1 && loading model acc… #166

merged 3 commits into from Jul 10, 2020

Conversation

hangtingchen
Copy link
Contributor

fix bugs in generating wsj0-mix dataset with wv1 instead of wv2 && loading model according to the epoch number

@mpariente
Copy link
Collaborator

Thanks a lot for the fix !
Next time, please make two separated PRs as those are two different problems, it makes easier to track changes afterwards.

mpariente
mpariente reviewed Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@mpariente mpariente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the two style issues I mentionned and this is good to be merged.
(You can tun black to indicate style issues).

egs/wsj0-mix/DeepClustering/model.py Outdated Show resolved Hide resolved
egs/wsj0-mix/DeepClustering/model.py Outdated Show resolved Hide resolved
@mpariente
Copy link
Collaborator

This will solve #164 and also #165 and the use of wv2 explained the poor performance in #138.

@hangtingchen
Copy link
Contributor Author

This will solve #164 and also #165 and the use of wv2 explained the poor performance in #138.

We have updated the code.

@mpariente
Copy link
Collaborator

Thanks !
The formatting is still not ok and I think you disabled "edit from the maintainers", I'll merge and fix it.

@mpariente mpariente merged commit 88bcd2b into asteroid-team:master Jul 10, 2020
This was referenced Jul 10, 2020
Closed
Closed
@hangtingchen
Copy link
Contributor Author

Thanks. Any guide for the coding style?

@mpariente
Copy link
Collaborator

https://github.com/psf/black

@mpariente mpariente mentioned this pull request Aug 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpariente mpariente mpariente left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hangtingchen @mpariente