Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request windows installer #27

Open
asianmusicguy opened this issue Feb 20, 2022 · 7 comments
Open

Feature Request windows installer #27

asianmusicguy opened this issue Feb 20, 2022 · 7 comments
Labels
packaging Affects releases windows Affects Windows wishlist Something that would be nice to have

Comments

@asianmusicguy
Copy link

It would be lovely if the program had a actual exe or MSI installer with a preferred directory like https://github.com/stax76/mpv.net/releases/tag/5.4.9.0 does?

@cmdrkotori cmdrkotori added the wishlist Something that would be nice to have label Feb 20, 2022
@SonaliBendre
Copy link

I've submitted PR to scoop/Extras repo to add mpc-qt
you can install it using scoop scoop install https://github.com/SonaliBendre/Extras/raw/master/bucket/mpc-qt.json
OR (try second method when my PR will be merged)
scoop add extras
scoop install mpc-qt

I had previously asked to write a Github Actions file to automatically build binaries for windows,linux and mac from git. Maybe someone who know bash/zsh can write one. the dev release windows file after only when he feels to so I think someone really should write a github actions file as github provides Linux/Windows/Mac VM for free. I know a guy @zhongfly to releases mpv latest build using github actions. I had requested him mpc-qt once

@cmdrkotori
Copy link
Contributor

The thing about github actions, @SonaliBendre, is that it requires that I be a package manager, sysop, and a script wizard with the patience and memory of a saint, and I'm a programmer not a package manager. The best I can do is slap a zipfile together occasionally and call it a day, or what is otherwise known as a portable release. The other thing is I simply don't see the need for CI right now.

Perhaps one day I'll work out NSIS to make an exe, or port the mac-orientated travis-ci already in this repo over to github actions, but today is not that day. If you desperately want the latest and greatest from git head, learn to compile from source. The step-by-step instructions on how to do so are already there in the README, so there's no excuse.

In any case I'll sooner make an installable exe rather than pony up the time needed to do github actions. And besides, implementing github actions before you've made scripts to generate a dmg or exe is putting the cart before the horse. So this issue is staying open for now.

@cmdrkotori cmdrkotori added the packaging Affects releases label Feb 21, 2022
@asianmusicguy
Copy link
Author

lol i feel like my request was hijacked a bit :P

@cmdrkotori
Copy link
Contributor

I still consider this a request to make an windows installer.

@SonaliBendre
Copy link

If you desperately want the latest and greatest from git head, learn to compile from source.

I install mpc-qt from AUR package in WSL using yay

@cmdrkotori cmdrkotori added the windows Affects Windows label Apr 1, 2022
@SonaliBendre
Copy link

.github/workflows/mpc-qt.yml

name: Build mpc-qt

on:
  workflow_dispatch:
    inputs:
      libmpv_url:
        description: 'input libmpv(mpv-dev-x86_64-*.7z) download url'
        required: true
      yt-dlp_url:
        description: 'input yt-dlp.exe download url'
        required: true

jobs:
  build:
    runs-on: windows-2022
    defaults:
      run:
        shell: msys2 {0}

    steps:
      - uses: actions/checkout@v3
        with:
          repository: mpc-qt/mpc-qt
          fetch-depth: 1 
      - uses: msys2/setup-msys2@v2
        with:
          msystem: mingw64
          update: true
          install: >-
            base-devel
            wget
            p7zip
            mingw-w64-x86_64-toolchain
            mingw-w64-x86_64-qt5
            mingw-w64-x86_64-qt-creator
            mingw-w64-x86_64-imagemagick
            mingw-w64-x86_64-librsvg
            mingw-w64-x86_64-inkscape
      - name: Download libmpv
        run: |
          wget -nv -O libmpv.7z ${{ github.event.inputs.libmpv_url }}
          7z x -y libmpv.7z -olibmpv
          cp -f libmpv/* mpv-dev/lib || true
          cp -f libmpv/include/* mpv-dev/include/mpv || true
          wget -nv -O binaries/yt-dlp.exe ${{ github.event.inputs.yt-dlp_url }}
      - name: Build
        run: |
          chmod +x *.sh
          set +e
          bash make-win-icon.sh
          bash make-release-win.sh
      - name: Upload
        uses: actions/upload-artifact@v3
        with:
          name: "mpc-qt-win"
          path: mpc-qt-*.zip

@he3als
Copy link

he3als commented Jan 2, 2024

https://github.com/he3als/mpc-qt-assoc-install

For file associations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Affects releases windows Affects Windows wishlist Something that would be nice to have
Projects
None yet
Development

No branches or pull requests

4 participants