Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watermark Font Size #1951

Closed
rikgirbes opened this issue Nov 8, 2023 · 5 comments
Closed

Watermark Font Size #1951

rikgirbes opened this issue Nov 8, 2023 · 5 comments

Comments

@rikgirbes
Copy link

Please describe the new functionality as best as you can.

The font size for a Water Mark is statically set to 120.

(Lines 13233-13235 in Mpdf.php)

if (($this->watermarkText) && ($this->showWatermarkText)) {
     $this->watermark($this->watermarkText, $this->watermarkAngle, 120, $this->watermarkTextAlpha); // Watermark text
}

Adding a Watermark through the WatermarkText object, should also be able to change the font size imo.

So quite an easy fix I'd say, add a parameter to the WatermarkText object (fontSize), set it default to 120, then it is changeable.

@finwe
Copy link
Member

finwe commented Nov 8, 2023

WatermarkText object already has a size parameter, this was just overlooked.

@rikgirbes
Copy link
Author

Size parameter however is not working, at least not for the Text-Watermark.
The only thing that can make it smaller or bigger would be the font size. Which is fixed to 120.

@finwe
Copy link
Member

finwe commented Nov 8, 2023

No, since commit d748f1e it is not. I meant overlooked by me.

@rikgirbes
Copy link
Author

Ah, awesome 😊 thanks!

Side question: when is a new release planned?

@finwe
Copy link
Member

finwe commented Nov 8, 2023

When I feel that it is justified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants