libxeve 0.5.1 tag build error with ffmpeg 7.0.1

[wader]

Not sure if 0.5.1 has been released yet but an automated update build triggered on the new tag failed with this:

...
libavcodec/libxeve.c:199:27: error: incompatible types when assigning to type 'XEVE_RATIONAL' {aka 'struct _XEVE_RATIONAL'} from type 'long int'
  199 |         cdsc->param.fps = lrintf(av_q2d(avctx->framerate));
      |                           ^~~~~~
libavcodec/libxeve.c: In function 'libxeve_encode':
libavcodec/libxeve.c:484:40: error: incompatible types when assigning to type 'int' from type 'XEVE_RATIONAL' {aka 'struct _XEVE_RATIONAL'}
  484 |                 avpkt->time_base.den = xectx->cdsc.param.fps;
      |                                        ^~~~~

[dariusz-f]

Yes, API was changed and need to be updated on FFmpeg side. Soon we will prepare patch.

[wader]

👍 close issue or let it be open until patch has been merged?

[dariusz-f]

Problem exists, so keep issue opened.

[dkozinski]

Not sure if 0.5.1 has been released yet but an automated update build triggered on the new tag failed with this:

...
libavcodec/libxeve.c:199:27: error: incompatible types when assigning to type 'XEVE_RATIONAL' {aka 'struct _XEVE_RATIONAL'} from type 'long int'
  199 |         cdsc->param.fps = lrintf(av_q2d(avctx->framerate));
      |                           ^~~~~~
libavcodec/libxeve.c: In function 'libxeve_encode':
libavcodec/libxeve.c:484:40: error: incompatible types when assigning to type 'int' from type 'XEVE_RATIONAL' {aka 'struct _XEVE_RATIONAL'}
  484 |                 avpkt->time_base.den = xectx->cdsc.param.fps;
      |                                        ^~~~~

I've just submitted a patch to the FFmpeg project that fixes the problem.

https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240625122016.862-1-d.kozinski@samsung.com/

[dkozinski]

The patch has just been merged to the FFmpeg

[dariusz-f]

Need to test and confirm this with latest FFmpeg HEAD. After sucessfull test we can close this issue.