Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JARs exported from modules should not be duplicated as dependency of dependent module #32

Closed
retronym opened this issue Nov 26, 2010 · 5 comments

Comments

@retronym
Copy link
Contributor

SBT doesn't really do this part correctly, see http://code.google.com/p/simple-build-tool/issues/detail?id=44

But the plugin could work around this by omitting jars as a direct dependency of module A, if that jar was exported by a module B, where A depends on B.

Alternatively, JAR dependencies could be marks as not 'exported' in the IntelliJ config.

Having the same jar repeated on the classpath leads to annoyances like this error with SLF4J:

SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/E:/code/analytics/analytics-test-support/lib_managed/scala_2.8.1/compile/logback-classic-0.9.24.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/E:/code/analytics/analytics-utils/lib_managed/scala_2.8.1/compile/logback-classic-0.9.24.jar!/org/slf4j/impl/StaticLoggerBinder.class]

@ijuma
Copy link
Contributor

ijuma commented Nov 26, 2010

It would certainly be nice if we removed duplicated jars. It would make IDEA indexing faster, reduce memory usage and avoid the issue where there are many duplicates in the Open Class dialog.

You make a good point that we can possibly fix this without having to wait for SBT 0.9.x.

@jrudolph
Copy link
Contributor

I tried to fix it. See pull request in issue #46.

@ijuma
Copy link
Contributor

ijuma commented Feb 21, 2011

Nice. :)

@mpeltonen
Copy link
Owner

Fix merged. Thanks!

@ijuma
Copy link
Contributor

ijuma commented Feb 22, 2011

I filed issue #48 for a similar thing to be done with the scala library. Johannes, do you want to tackle that too? :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants