Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ring binary search implementation is slow #307

Closed
tmm1 opened this issue Dec 15, 2012 · 3 comments
Closed

Ring binary search implementation is slow #307

tmm1 opened this issue Dec 15, 2012 · 3 comments

Comments

@tmm1
Copy link
Contributor

tmm1 commented Dec 15, 2012

Accounts for 15% in ruby-prof benchmarks. This is compounded by the fact that there are 160 Ring::Entry per server.
@mperham
Copy link
Collaborator

mperham commented Dec 15, 2012

Idea: Pull out the RubyInline binary impl in memcache-client and shoe horn it into Dalli. Rerun your benchmarks.

@tmm1
Copy link
Contributor Author

tmm1 commented Dec 15, 2012

ruby2 has an Array#bsearch. I'd rather backport that into a cext gem and add that as a dependency.

@mperham
Copy link
Collaborator

mperham commented Dec 15, 2012

Try the native_search branch. gem install RubyInline first. See what difference it makes.

mperham added a commit that referenced this issue Jan 25, 2013
@mperham
pull in native search via rubyinline, #307
bb43dc3
@mperham mperham closed this as completed May 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmm1 @mperham