Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekiq.inline interferes/interacts with transactions? #1405

Closed
skwp opened this issue Dec 20, 2013 · 1 comment
Closed

Sidekiq.inline interferes/interacts with transactions? #1405

skwp opened this issue Dec 20, 2013 · 1 comment

Comments

@skwp
Copy link

skwp commented Dec 20, 2013

I can't explain this at all, but tagging my test with sidekiq: :inline, using this spec_helper:

  config.before(:each, sidekiq: :inline) do
    Sidekiq::Testing.inline!
  end

  # Ensure we are not invoking sidekiq after setting it to inline above.
  config.after(:each, sidekiq: :inline) do
    Sidekiq::Testing.fake!
  end

The test starts behaving strangely. Specifically, my after_commit hooks stop firing. I can still see COMMIT in the db log, but somehow just adding sidekiq has caused this issue. I have verified that adding any other tag like foo: bar to the spec will not affect the behavior, but adding sidekiq inline does.

I read through the code and don't see any interaction with transactions. Has anyone come across this at all?

@skwp
Copy link
Author

skwp commented Dec 20, 2013

My fault, something in a sidekiq job was hitting webmock and apparently triggering a rollback.

@skwp skwp closed this as completed Dec 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant