Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sinatra? #2313

Closed
mperham opened this issue Apr 22, 2015 · 16 comments
Closed

Remove Sinatra? #2313

mperham opened this issue Apr 22, 2015 · 16 comments

Comments

@mperham
Copy link
Collaborator

mperham commented Apr 22, 2015

What would it take to remove our Sinatra dependency? Can we ship the Sidekiq Web UI using bare Rack only?

@tarcieri
Copy link

Perhaps you could use Angelo instead of Sinatra?

https://github.com/kenichi/angelo

cc @kenichi

@mperham
Copy link
Collaborator Author

mperham commented Apr 22, 2015

That would add more gem dependencies overall, arguably a net negative.

@w-A-L-L-e
Copy link

What's wrong with sinatra rb ? It's always just worked fine for me?

@mperham
Copy link
Collaborator Author

mperham commented Apr 22, 2015

I didn't say there was anything wrong with Sinatra but it's one more gem that users need in their Gemfile to use the Web UI.

@w-A-L-L-e
Copy link

Ow ok. Keep up the great work with sidekiq it's one of my favourite gems ;).

@mperham
Copy link
Collaborator Author

mperham commented Apr 22, 2015

👍

@kenichi
Copy link

kenichi commented Apr 23, 2015

thanks for the thought, @tarcieri. for sidekiq/web, "rack-able" is probably a key feature, no?. on the rack side of things, i've been using roda lately and really like it, but still not "bare rack".

@tarcieri
Copy link

Yeah nm 😉 Just thought it might be cool in this use case (e.g. if you had realtime websockets reports of what's happening)

@mperham
Copy link
Collaborator Author

mperham commented Apr 23, 2015

It would be totally sweet but I think that Reel requires an ops cost which Sidekiq can't demand.

@tarcieri
Copy link

@kenichi's point about mounting it as rack middleware is spot on. That's the way we run a lot of our Sidekiq dashboards at Square

@davydovanton
Copy link
Contributor

Mike, good idea, but I have some questions:

  1. What will we do with projects(or plugins) that aren't supported for a long time but it used with sidekiq? (for example sidetiq)
  2. Sinatra gives simple and userful DSL based on rack. How difficult is it to maintain a clean rack application?

@mperham
Copy link
Collaborator Author

mperham commented Apr 23, 2015

1 is a great point, we'd have to allow some sort of extension point, ideally with an identical or similar API. We can break the API but only at 4.0.

2 is unknown. This issue is really just a thought and requires some serious prototyping and experimentation to determine if it's really possible.

@davydovanton
Copy link
Contributor

Mike, what do you want to use? I think that I can try create branch with vanilla rack application tomorrow.

@mperham
Copy link
Collaborator Author

mperham commented Apr 23, 2015

Just plain rack.

On Apr 23, 2015, at 18:35, Anton Davydov notifications@github.com wrote:

Mike, what do you want to use? I think that I can try create branch with vanilla rack application tomorrow.


Reply to this email directly or view it on GitHub.

@davydovanton
Copy link
Contributor

okay 👍

@mperham
Copy link
Collaborator Author

mperham commented Jun 10, 2015

In retrospect this seems like a pretty big change. Closing as not worth it.

@mperham mperham closed this as completed Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants