New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Sinatra? #2313
Comments
Perhaps you could use Angelo instead of Sinatra? https://github.com/kenichi/angelo cc @kenichi |
That would add more gem dependencies overall, arguably a net negative. |
What's wrong with sinatra rb ? It's always just worked fine for me? |
I didn't say there was anything wrong with Sinatra but it's one more gem that users need in their Gemfile to use the Web UI. |
Ow ok. Keep up the great work with sidekiq it's one of my favourite gems ;). |
👍 |
thanks for the thought, @tarcieri. for sidekiq/web, "rack-able" is probably a key feature, no?. on the rack side of things, i've been using roda lately and really like it, but still not "bare rack". |
Yeah nm 😉 Just thought it might be cool in this use case (e.g. if you had realtime websockets reports of what's happening) |
It would be totally sweet but I think that Reel requires an ops cost which Sidekiq can't demand. |
@kenichi's point about mounting it as rack middleware is spot on. That's the way we run a lot of our Sidekiq dashboards at Square |
Mike, good idea, but I have some questions:
|
1 is a great point, we'd have to allow some sort of extension point, ideally with an identical or similar API. We can break the API but only at 4.0. 2 is unknown. This issue is really just a thought and requires some serious prototyping and experimentation to determine if it's really possible. |
Mike, what do you want to use? I think that I can try create branch with vanilla rack application tomorrow. |
Just plain rack.
|
okay 👍 |
In retrospect this seems like a pretty big change. Closing as not worth it. |
What would it take to remove our Sinatra dependency? Can we ship the Sidekiq Web UI using bare Rack only?
The text was updated successfully, but these errors were encountered: