-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Celluloid, remove defer usage #919
Comments
Note that task_class TaskThread ...inside of processor to get this behavior. That said, TaskThreads are actually tested now :O |
Good to know. Using an actual constant makes it hard to stub out Celluloid in testing. I'd prefer a symbol, e.g. Do I lose anything using threads rather than fibers? Will signals still work? |
We can add a symbol as a shortcut. Threads are a bit trickier to for us to manage and I think there may be some issues with shutdown that remain in 0.14 (specifically that the thread pool isn't correctly reaped. In theory they're also more heavyweight, but it seems like the 4kB stack size is a far more pressing issue, and with defer you're using both anyway. |
Following [sidekiq's lead][1] this is no longer necessary. It also means that `Shoryuken::Shutdown` will be raised on the worker thread which, in turn means it is possible to create middleware that respond to it. [1]: sidekiq/sidekiq#919
Use of defer was necessary when Celluloid message dispatch was done within fibers. This requires twice the number of threads. Remove it now that thread dispatch is the default.
The text was updated successfully, but these errors were encountered: