Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "latency" stat in the dashboard #1230

Merged
merged 2 commits into from Oct 4, 2013
Merged

Conversation

jlecour
Copy link
Contributor

@jlecour jlecour commented Oct 4, 2013

I've added the latency metric in the /dashboard/stats response.

It is useful to collect metrics (for Munin or else) without using Ruby and Sidekiq's DSL at all.

@mperham
Copy link
Collaborator

mperham commented Oct 4, 2013

That's the latency for the default queue. Maybe the metric should be called default_latency?

@mperham
Copy link
Collaborator

mperham commented Oct 4, 2013

It would be useful to document /dashboard/stats on the Monitoring page.

@jlecour
Copy link
Contributor Author

jlecour commented Oct 4, 2013

I didn't realize that it was for the default queue but it makes total sense.

I guess we could have many possibilities :

  • only the default queue
  • each queue separately
  • an average of all queues

Do you know if Sidekiq users usually have many queues or just a few? I have 3-5.

@mperham
Copy link
Collaborator

mperham commented Oct 4, 2013

We only have two: default and low. I think default is the only one we
should support.

On Fri, Oct 4, 2013 at 8:21 AM, Jérémy Lecour notifications@github.comwrote:

I didn't realize that it was for the default queue but it makes total
sense.

I guess we could have many possibilities :

  • only the default queue
  • each queue separately
  • an average of all queues

Do you know if Sidekiq users usually have many queues or just a few? I
have 3-5.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1230#issuecomment-25706771
.

@jlecour
Copy link
Contributor Author

jlecour commented Oct 4, 2013

The more I think about this the more I'd like to be able to customize this stat view, or add a custom one with my own use of Sidekiq's internal API.

Since it reflects only the latency of the default queue
it's more expressive like this.
@jlecour
Copy link
Contributor Author

jlecour commented Oct 4, 2013

If you merge this PR, I'll update the Monitoring page on the wiki.

mperham added a commit that referenced this pull request Oct 4, 2013
Add a "latency" stat in the dashboard
@mperham mperham merged commit 14db487 into sidekiq:master Oct 4, 2013
@mperham
Copy link
Collaborator

mperham commented Oct 4, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants