Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to remove the generic aliases which MAY clash #1674

Merged
merged 1 commit into from
May 21, 2014

Conversation

devaroop
Copy link
Contributor

This pull request solves #1647.

Please add Sidekiq.namespace_delay_methods to your config/initializers/sidekiq.rb and the DangerousAttributeErrors will go away.

Instead of the delay, delay_for and delay_until methods,
use
sidekiq_delay
sidekiq_delay_for and
sidekiq_delay_until respectively

Hope this helps

@mperham
Copy link
Collaborator

mperham commented Apr 24, 2014

I'd rather see a flag to disable the extensions being added in the first place.

@devaroop
Copy link
Contributor Author

@mperham - you are right. I have tried ways to add a flag before extensions are added.

BUT the gem loads into the stack before any flag / settings in initializers are called. So, for an end user to avoid those methods, he has to manually modify the gem and set the flag - Not possible.

Any thoughts / ideas? I will be happy to implement

@mperham
Copy link
Collaborator

mperham commented May 21, 2014

Thanks, after spending a bit of time thinking about it I think your approach is the easiest solution. It's not pretty but I don't see any easy clean solution. Thanks for the PR!

mperham added a commit that referenced this pull request May 21, 2014
Option to remove the generic aliases which MAY clash
@mperham mperham merged commit aec5397 into sidekiq:master May 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants