Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update application.css #2263

Closed
wants to merge 1 commit into from
Closed

Update application.css #2263

wants to merge 1 commit into from

Conversation

fuhaixiao
Copy link

移除googlefonts引用,天朝政府我艹尼玛

移除googlefonts引用,天朝政府我艹尼玛
@aprescott
Copy link
Contributor

Instead of removing these fonts altogether, perhaps they could be downloaded and stored locally?

@mperham
Copy link
Collaborator

mperham commented Mar 25, 2015

#2144 I thought we had already removed Google fonts for Chinese users?

@aprescott
Copy link
Contributor

Oh, weird. They're not in master. I have no idea why git/github would show a diff for this commit...

@mperham
Copy link
Collaborator

mperham commented Mar 25, 2015

It's not in master: https://github.com/mperham/sidekiq/blob/master/web/assets/stylesheets/application.css

We do need to remove the Google font names from font-family.

@mperham mperham closed this Mar 25, 2015
@mperham
Copy link
Collaborator

mperham commented Mar 25, 2015

@x235 I think you need to pull the latest master. This was removed in 3.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants