Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Bindings (partial) chapter RC review #368

Closed
2 tasks
jsquyres opened this issue Dec 2, 2020 · 2 comments
Closed
2 tasks

Language Bindings (partial) chapter RC review #368

jsquyres opened this issue Dec 2, 2020 · 2 comments
Assignees
Labels
chap-bindings Language Bindings Chapter Committee Chapter Committee Change Changes to be made by the respective chapter committee(s)
Milestone

Comments

@jsquyres
Copy link
Member

jsquyres commented Dec 2, 2020

From reviewing pages 779-780 in the Nov 2020 4.0 RC document:

  • p779 31, 37, and 41: I've long-thought that the "USE mpi_f08", "USE mpi", and "INCLUDE 'mpif.h'" were in the wrong font. Shouldn't they be fixed-width instead of boldface?
  • p780 1: "Compliant MPI-3 implementations..." --> "Compliant MPI implementations"
    • Meaning: this doc is MPI-4.0. We're talking about the MPI implementation in this doc, which is 4.0. If we only talk about MPI-3 implementations, this doesn't technically include MPI-3.1 or MPI-4.0.
@jsquyres jsquyres added mpi-4.0 chap-bindings Language Bindings Chapter Committee Chapter Committee Change Changes to be made by the respective chapter committee(s) labels Dec 2, 2020
@wgropp
Copy link

wgropp commented Dec 2, 2020

I agree with both. Though there is some inconsistency in exactly how these are shown in text, but they are consistently in \code{}, which is a fixed-width font.

Good catch on the "Compliant MPI-3 implementations"!

@wesbland wesbland added this to Triage in MPI 4.0 Ratification via automation Dec 3, 2020
@wesbland wesbland added this to the 2020-12 milestone Dec 3, 2020
@wesbland wesbland moved this from Triage to To Do for MPI 4.0 in MPI 4.0 Ratification Dec 7, 2020
@RolfRabenseifner
Copy link

Through Change-log and the rules about MPI_Get_version (can return from 1.1? until 4.0), and other wording in this standard, the better wording may be:

p780 1: "Implementations compliant to MPI-3.0 and later providing a Fortran interface must provide one or both of the following:"

or

"Since MPI-3.0, compliant MPI implementations providing a Fortran interface must provide one or both of the following:"

@wesbland wesbland closed this as completed Jan 8, 2021
MPI 4.0 Ratification automation moved this from To Do for MPI 4.0 to Done Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chap-bindings Language Bindings Chapter Committee Chapter Committee Change Changes to be made by the respective chapter committee(s)
Projects
No open projects
Development

No branches or pull requests

6 participants