Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MPI_HOST #57

Closed
jdinan opened this issue Sep 3, 2016 · 14 comments
Closed

Deprecate MPI_HOST #57

jdinan opened this issue Sep 3, 2016 · 14 comments
Assignees
Labels
chap-environment MPI Environmental Management Chapter Committee had reading Completed the formal proposal reading mpi-4.1 For inclusion in the MPI 4.1 standard passed final vote Passed the final formal vote passed first vote Passed the first formal vote
Projects
Milestone

Comments

@jdinan
Copy link

jdinan commented Sep 3, 2016

Summary

The MPI_HOST attribute on MPI_COMM_WORLD is ambiguous and no longer relevant for MPI implementations. This was reviewed at the September, 2015 meeting and there was consensus that it should be deprecated.

Proposed Change

Page 228, lines 3-4: Remove or reword sentence containing "host process"

Page 335, line 4: Remove line beginning with "MPI_HOST"

Page 335, lines 27-33: Remove "Host Rank" subsection.

Page 675, line 47: Remove "MPI_HOST" from "Environmental inquiry keys" table

@abouteiller
Copy link
Member

This issue has been duplicated by #201

@wesbland wesbland added editor pass mpi-4.1 For inclusion in the MPI 4.1 standard chap-environment MPI Environmental Management Chapter Committee labels Apr 13, 2020
@wesbland wesbland added this to Awaiting Implementation in Editor Pass Status Apr 13, 2020
@wesbland wesbland removed this from Awaiting Implementation in Editor Pass Status Apr 29, 2020
@jaegerj
Copy link
Member

jaegerj commented May 20, 2020

Annotated MPI 4.0 pdf with red changebars.
Changes are listed on first page.
mpi40-report-deprecate-MPI_HOST.pdf

And annotated MPI 3.1 pdf for comparison
mpi31-report_depracate_MPI_HOST.pdf

@RolfRabenseifner
Copy link

RolfRabenseifner commented Jan 28, 2021

A deprecated feature is still available and must be therefore fully explained. The following text from MPI-3 and MPI-4 is missing in the proposed pdf:

The value returned for MPI_HOST gets the rank of the HOST process in the group associated
with communicator MPI_COMM_WORLD, if there is such. MPI_PROC_NULL is returned if
there is no host. MPI does not specify what it means for a process to be a HOST, nor does
it requires that a HOST exists.
The attribute MPI_HOST has the same value on all processes of MPI_COMM_WORLD.

Also in Annex A.1, the constant MPI_HOST must not be removed.

Recommendation: Add only comments that MPI_Host is deprecated since MPI-4.x in the appropriate section and A.1.1. The additional text in the Deprecated chapter and the change-log is then enough.

And it must be listed in Table 2.1 also missing in PR https://github.com/mpi-forum/mpi-standard/pull/221

@jaegerj
Copy link
Member

jaegerj commented Jan 28, 2021

Hi Rolf,

yes, I did not take the time to correct this PR yet. This is not intended to 4.0 anymore. I plan to update the PR after the next meeting.

@RolfRabenseifner
Copy link

If a feature is such integrated in other parts of the standard (as in the past the C++ interface, see MPI-2.2), then the best way may be to keep the existing text, i.e., to start with a new PR from final MPI-4.0, and to add only deprecation remarks at the definition of MPI_HOST, at the repeating in A.1.1, and to add a list entry in Table 2.1, a paragraph to the Deprecated chapter, and an entry in the change-log.
I saw that you flagged with MPI-4.1.

@wesbland
Copy link
Member

wesbland commented Feb 1, 2021

You don't need to close the PR. Just push updates to it...

@wesbland
Copy link
Member

wesbland commented Dec 8, 2022

This wasn't read at the December 2022 meeting. The last opportunity for MPI 4.1 is to have it ready at the March 2022 meeting (and it needs to "pass" the reading).

@jaegerj Are you (or is someone else) planning to push this forward or should we move it out of the plan for MPI 4.1?

@schulzm
Copy link

schulzm commented Dec 9, 2022

This is scheduled for discussion in the virtual meeting on January 11th

@wesbland wesbland added the scheduled reading Reading is scheduled for the next meeting label Jan 17, 2023
@wesbland wesbland added the had reading Completed the formal proposal reading label Feb 8, 2023
@RolfRabenseifner
Copy link

@jaegerj When you announce the 1st vote, you may mention that there were a view editorial changes since the reading.

@wesbland wesbland added the no-no Requires a no-no vote label Mar 1, 2023
@wesbland wesbland removed this from the February 2023 milestone Mar 1, 2023
@wesbland wesbland added this to the March 2023 milestone Mar 1, 2023
@wesbland wesbland added scheduled vote and removed scheduled reading Reading is scheduled for the next meeting labels Mar 1, 2023
@wesbland
Copy link
Member

There's two PRs that point back to this issue. Which one is the one that was voted on?

@jaegerj
Copy link
Member

jaegerj commented Mar 16, 2023

The most recent one: https://github.com/mpi-forum/mpi-standard/pull/790

@mpiforumbot
Copy link

This passed a no-no vote.

Yes No Abstain
31 0 0

@mpiforumbot mpiforumbot removed no-no Requires a no-no vote scheduled vote labels Mar 21, 2023
@mpiforumbot
Copy link

This passed a 1st vote.

Yes No Abstain
29 0 2

@mpiforumbot mpiforumbot added the passed first vote Passed the first formal vote label Mar 21, 2023
@wesbland wesbland modified the milestones: March 2023, May 2023 Apr 6, 2023
@wesbland wesbland added scheduled second vote Second vote is scheduled for the next meeting and removed scheduled vote labels May 3, 2023
@wesbland
Copy link
Member

wesbland commented May 3, 2023

This passed a 2nd vote.

Yes No Abstain
28 0 4

@wesbland wesbland added passed final vote Passed the final formal vote and removed scheduled second vote Second vote is scheduled for the next meeting labels May 3, 2023
@wgropp wgropp closed this as completed May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chap-environment MPI Environmental Management Chapter Committee had reading Completed the formal proposal reading mpi-4.1 For inclusion in the MPI 4.1 standard passed final vote Passed the final formal vote passed first vote Passed the first formal vote
Projects
No open projects
MPI 4.1
In Progress
Status: Done
Development

No branches or pull requests

7 participants