Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI_T ABI #835

Open
jeffhammond opened this issue Feb 22, 2024 · 1 comment
Open

MPI_T ABI #835

jeffhammond opened this issue Feb 22, 2024 · 1 comment
Assignees
Labels
mpi-4.2 wg-tools Tools Working Group
Milestone

Comments

@jeffhammond
Copy link
Member

Problem

The constants in the MPI tools interface need to be defined in the ABI.

Proposal

Somebody from the Tools WG needs to provide values to e.g. https://github.com/mpiwg-abi/header_and_stub_library/blob/main/mpi.h#L493.

Changes to the Text

TODO

Impact on Implementations

Necessary for ABI.

Impact on Users

Necessary for ABI.

References and Pull Requests

@jeffhammond jeffhammond added the wg-tools Tools Working Group label Feb 22, 2024
@jeffhammond jeffhammond added this to the March 2024 milestone Feb 22, 2024
@mahermanns
Copy link
Member

As per discussion in the Tools WG call on Mar 04, 2024:

  • MPI_T_ERR_XXX need to adhere to the restrictions of error codes (i.e., ranges of values, etc.)
  • It might be of benefit to have different constant groups "own" different bitmasks (i.e., make any MPI_T_BIND_xxx distinguishable from MPI_T_PVAR_CLASS_xxx ... but this would be an interesting benefit, not strictly required
  • The MPI_T_CB_xxx constants form a hierarchy, so in principle one could make them some form of bitfield, but it is also not strictly required, as they are not used in the bitfield-ish way of ORing multiple of those constants anyway. Again, this may add comfort, but as long as they are strictly distinct, I think, this should be OK.

We didn't get to checking for all MPI_T constants in the call and more discussion seems to be in order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mpi-4.2 wg-tools Tools Working Group
Projects
Status: In Progress
Development

No branches or pull requests

5 participants