Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of monadic code results in code that is parenthesized erroneously #124

Closed
Aster89 opened this issue Mar 24, 2022 · 2 comments · Fixed by ndmitchell/hlint#1367
Closed

Refactoring of monadic code results in code that is parenthesized erroneously #124

Aster89 opened this issue Mar 24, 2022 · 2 comments · Fixed by ndmitchell/hlint#1367

Comments

@Aster89
Copy link

Aster89 commented Mar 24, 2022

The code

f = const [] . (>>= const Nothing) . const Nothing

is refactored to

f = const [] . const Nothing <=< const Nothing

which is wrong, instead of

f = const [] . (const Nothing <=< const Nothing)

which is correct.

Originally filed the report on HLS.
@zliu41 zliu41 mentioned this issue Mar 26, 2022
Closed
@zliu41
Copy link
Collaborator

zliu41 commented Mar 26, 2022

Thanks for reporting the bug, @Aster89. I believe this should be taken care of on the HLint side, so I opened ndmitchell/hlint#1364.

@zliu41 zliu41 mentioned this issue Mar 27, 2022
Merged
@zliu41
Copy link
Collaborator

zliu41 commented Mar 28, 2022

The fix has been merged into HLint master.

@zliu41 zliu41 closed this as completed Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add brackets on refactoring templates when needed zliu41/hlint
2 participants
@zliu41 @Aster89