Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't look for NIX_GHC_LIBDIR as it is redundant #294

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Apr 25, 2021

Closes #273

@mpickering
Copy link
Collaborator

LGTM.

@bgamari
Copy link

bgamari commented Apr 25, 2021

Yes, I agree, there is not reason to look at NIX_GHC_LIBDIR.

@fendor fendor merged commit 461ef20 into haskell:master Apr 25, 2021
@jneira
Copy link
Member

jneira commented Apr 25, 2021

it is being used in ghcide, so we should remove it there too
https://github.com/haskell/haskell-language-server/blob/17fce672402f22944527c616a0c4015df1ffb750/ghcide/session-loader/Development/IDE/Session/VersionCheck.hs#L17

fendor added a commit to fendor/hie-bios that referenced this pull request Aug 30, 2021
fendor added a commit to fendor/hie-bios that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using NIX_GHC_LIBDIR is surprising and undocumented
4 participants