Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of dependencies #5

Open
4 tasks
mpizenberg opened this issue Mar 25, 2019 · 0 comments
Open
4 tasks

Reduce the number of dependencies #5

mpizenberg opened this issue Mar 25, 2019 · 0 comments

Comments

@mpizenberg
Copy link
Owner

  • Input-Output (IO) should be independent from this library. This concerns the image, png, byteorder and nom crates.
  • itertools is used only once for the izip function, to zip 3 vectors in the same loop. It probably isn't worth the dependency.
  • num-traits is only used in dso candidates selection implementation for the Number trait. Maybe there is a way of doing it without the dependency. Maybe it shouldn't even be generic since for now, this implementation is only done for u16 gradient images.
  • Random number generation is only used in candidates::dso. DSO is also the cause of num-traits, and one implementation should not bring too many dependencies. It might be a good idea to make candidates selection a trait somehow, and separate coarse to fine and dso's implementations into another code base?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant